Skip to content

4024_trial: bug fix and polishing #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 4, 2024
Merged

4024_trial: bug fix and polishing #303

merged 2 commits into from
Sep 4, 2024

Conversation

jglander
Copy link
Contributor

@jglander jglander commented Sep 4, 2024

Purpose

  • add missing origin in Launchpad_Admin role_collection_assignment
  • add optional (cf) application runtime entitlement
  • consistency (with 3585) polishing

Pull Request Type

[x] Bugfix
[ ] Feature
[ ] Documentation content changes
[ ] Other... Please describe:

@jglander
4024_trial: bug fix and polishing
74ddd8f 
- add missing origin in Launchpad_Admin role_collection_assignment
- add optional (cf) application runtime entitlement
- consistency (with 3585) polishing
lechnerc77
lechnerc77 approved these changes Sep 4, 2024
View reviewed changes
Copy link
Member

@lechnerc77 lechnerc77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lechnerc77 lechnerc77 enabled auto-merge (squash) September 4, 2024 06:53
@lechnerc77 lechnerc77 merged commit d6de43d into SAP-samples:main Sep 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lechnerc77 lechnerc77 lechnerc77 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jglander @lechnerc77